Uh oh!
There was an error while loading. Please reload this page.
[stable27] Fix/2708 pasting tables - #4313
Merged
Merged
Conversation
Signed-off-by: Max <max@nextcloud.com>
Fixes#2708. Try to read the first table row as headings. Pasting works via `insertContent` while opening uses `setContent`. They use the schema in different ways. So we also need to make sure to test both for some corner cases. `setContent` is fairly flexible in turning the input into a valid document structure. `insertContent` however fails to resolve structures that would require picking lower priority parent elements. Note: Some tests in src/tests/nodes/Table.spec.js fail when using `insertContent` instead of `setContent`. Pasting the correponding html table is fixed never the less. Signed-off-by: Max <max@nextcloud.com>
backportbot-nextcloudBot
requested review from
juliusknorr, max-nextcloud and mejo-June 19, 2023 18:22
mejo-
commented
Jun 19, 2023
Member
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2 flaky tests on run #10271 ↗︎
Details:
| |||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection | OutputScreenshots | |
share.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error | OutputScreenshots | |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mejo-
approved these changes
Jun 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4285