Skip to content

[stable26] Bring back keyboard shortcuts to help modal on non-mobile - #4319

Merged
juliusknorr merged 3 commits into
stable26from
backport/4251/stable26
Jun 22, 2023
Merged

[stable26] Bring back keyboard shortcuts to help modal on non-mobile#4319
juliusknorr merged 3 commits into
stable26from
backport/4251/stable26

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

Backport of #4251

@cypress

cypressBot commented Jun 20, 2023

Copy link
Copy Markdown

2 flaky tests on run #10426 ↗︎

014610Flakiness2

Details:

[stable26] Bring back keyboard shortcuts to help modal on non-mobile
Project: TextCommit:70734f2967
Status: PassedDuration: 03:08 💡
Started: Jun 22, 2023 9:00 PMEnded: Jun 22, 2023 9:03 PM
Flakiness nodes/HardBreak.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Hard break support > Can create hard breaks with shift+enter OutputScreenshots
Flakiness files.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Text and server mimetypes > handle plaintext in a pre tag OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

mejo- added 2 commits June 22, 2023 22:50
Cache result of method `isMobilePlatform()` as computed property, given
that it doesn't change within one browser anyway.
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@juliusknorr
juliusknorrforce-pushed the backport/4251/stable26 branch from efa758c to a1d0139CompareJune 22, 2023 20:50
@juliusknorr

Copy link
Copy Markdown
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr
juliusknorr merged commit 5db88ed into stable26Jun 22, 2023
@delete-merged-branch
delete-merged-branchBot deleted the backport/4251/stable26 branch June 22, 2023 21:03
@blizzzblizzz mentioned this pull request Jul 10, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr@mejo-@blizzz@nextcloud-command