Skip to content

[stable24] fix: Fetch attachment share permissions - #4490

Merged
juliusknorr merged 2 commits into
stable24from
backport/4481/stable24
Jul 12, 2023
Merged

[stable24] fix: Fetch attachment share permissions#4490
juliusknorr merged 2 commits into
stable24from
backport/4481/stable24

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Backport of #4481

@juliusknorrjuliusknorr added bug Something isn't working 3. to review labels Jul 11, 2023
@juliusknorr
juliusknorr requested review from blizzz and mejo-July 11, 2023 20:22
@cypress

cypressBot commented Jul 11, 2023

Copy link
Copy Markdown

Passing run #10986 ↗︎

05100Flakiness0

Details:

Merge caf90cf into cea1365...
Project: TextCommit:5bd581a989 ℹ️
Status: PassedDuration: 03:02 💡
Started: Jul 12, 2023 7:01 AMEnded: Jul 12, 2023 7:04 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@blizzz

blizzz commented Jul 11, 2023

Copy link
Copy Markdown
Member

There seems to be some compat issues with Guzzle https://github.com/nextcloud/text/actions/runs/5524518111/jobs/10076930887?pr=4490 on first sight… althought that looks unrealted. Still odd.

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Definitely odd, I also see this locally, but the issues seem to be there already just considered as suppressed on the stable24 branch

composer run psalm -- --no-cache --threads=8 --show-info=true already shows them on the base branch. Probably a psalm bug, let me add the guzzle classes to suppress for this one.

@juliusknorr
juliusknorrforce-pushed the backport/4481/stable24 branch from 821ad4b to d91a841CompareJuly 12, 2023 06:52
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Damn, I accidentially pushed cea1365 to stable24 directly 🙈 Let me rebase this one

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the backport/4481/stable24 branch from d91a841 to 822f918CompareJuly 12, 2023 06:55
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr
juliusknorr merged commit 3b61d8d into stable24Jul 12, 2023
@juliusknorr
juliusknorr deleted the backport/4481/stable24 branch July 12, 2023 07:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@blizzz@nextcloud-command