Skip to content

fix: remove duplicated save key action - #4495

Merged
mejo- merged 2 commits into
mainfrom
bugfix/remove-duplicated-save-key-action
Jul 12, 2023
Merged

fix: remove duplicated save key action#4495
mejo- merged 2 commits into
mainfrom
bugfix/remove-duplicated-save-key-action

Conversation

@luka-nextcloud

Copy link
Copy Markdown
Contributor

📝 Summary

🖼️ Screenshots

🏚️ Before🏡 After
BA

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress

cypressBot commented Jul 12, 2023

Copy link
Copy Markdown

1 failed and 2 flaky tests on run #10994 ↗︎

114720Flakiness2

Details:

fix: remove duplicated save key action
Project: TextCommit:bdfdff7d2a
Status: FailedDuration: 03:48 💡
Started: Jul 12, 2023 8:24 AMEnded: Jul 12, 2023 8:28 AM
Failed cypress/e2e/sync.spec.js • 1 failed test

ViewOutputVideo

Test Artifacts
Sync > recovers from a lost connection OutputScreenshots
Flakiness nodes/Mentions.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Test mentioning users > Type @ and see the user list OutputScreenshots
Flakiness files.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Text and server mimetypes > handle plaintext in a pre tag OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works like expected 😊

@luka-nextcloud could you take care of backporting this to stable27, stable26 and stable25?

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@mejo-
mejo-force-pushed the bugfix/remove-duplicated-save-key-action branch from 4792589 to e187a7cCompareJuly 12, 2023 08:17
@mejo-

Copy link
Copy Markdown
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo-
mejo- merged commit 7775c6b into mainJul 12, 2023
@delete-merged-branch
delete-merged-branchBot deleted the bugfix/remove-duplicated-save-key-action branch July 12, 2023 08:28
@mejo-

Copy link
Copy Markdown
Member

/backport e187a7c to stable27

@mejo-

Copy link
Copy Markdown
Member

/backport e187a7c to stable26

@mejo-

Copy link
Copy Markdown
Member

/backport e187a7c to stable25

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ctrl-S saves twice

3 participants

@luka-nextcloud@mejo-@nextcloud-command