Uh oh!
There was an error while loading. Please reload this page.
feat: add component SkeletonLoading - #4545
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
juliusknorr
commented
Jul 18, 2023
I've added a quick screen recording for easier review by the designers with my proposed changes. @marcoambrosini could you have a look? |
marcoambrosini
left a comment
There was a problem hiding this comment.
Looks much nicer than the spinner :)
the only thing I would add is a small border radius to the rectangles, maybe 4px?
juliusknorr
commented
Jul 19, 2023
I'd keep this separate, if this shall be done then it would be good to structure this so that every app using skeleton loaders adjusts for the same target nextcloud version :) |
Uh oh!
There was an error while loading. Please reload this page.
b70d227 to
c219eb1CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
c219eb1 to
c8b4cbeComparec8b4cbe to
8807857Compare
mejo-
left a comment
There was a problem hiding this comment.
@luka-nextcloud sorry for yet another round of feedback: both in src/components/Editor/Wrapper.vue and in src/views/RichWorkspace.vue there's leftovers in the CSS that refer to .icon-loading which is not used anymore. The ones in src/components/Editor/Wrapper.vue probably can be removed, the ones in src/view/RichWorkspace.vue look like they need to be updated to be active when this.loading is set, no?
Signed-off-by: Luka Trovic <luka@nextcloud.com>
8807857 to
b982efaComparemejo-
commented
Aug 2, 2023
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
juliusknorr
commented
Aug 8, 2023
/backport to stable27 |
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
mejo-
commented
Aug 8, 2023
/backport b982efa to stable27 |
📝 Summary
🖼️ Screenshots
🏚️ Before


🏡 After


🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)