Uh oh!
There was an error while loading. Please reload this page.
fix(css): Fix margin-bottom for list items - #4596
Merged
Merged
Conversation
1 flaky tests on run #11384 ↗︎
Details:
| |||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync service provider > recovers from a dropped message | OutputScreenshots | |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mejo-force-pushed
the
fix/list_item_margin_bottom
branch
from
July 28, 2023 13:52
aa3afa8 to
3fb57fbComparemax-nextcloud
approved these changes
Jul 28, 2023
Collaborator
There was a problem hiding this comment.
Code looks good. Maybe design review would make sense?
@jancborchardt@nimishavijay Could you check the screenshots in the description?
mejo-
commented
Jul 28, 2023
MemberAuthor
Given that it just fixes a regression, I'm sure it's the correct fix 😇 |
mejo-
commented
Jul 28, 2023
MemberAuthor
/compile |
nimishavijay
commented
Jul 28, 2023
Member
Looks good! :) |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
mejo-force-pushed
the
fix/list_item_margin_bottom
branch
from
July 28, 2023 14:28
227e4b9 to
0cfd1daComparemejo-
commented
Jul 28, 2023
MemberAuthor
/backport dee7cea to stable27 |
mejo-
commented
Jul 28, 2023
MemberAuthor
/backport dee7cea to stable26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4547
Required after 774a42b.