Skip to content

fix: Properly handle viewer loading in collectives - #4657

Merged
mejo- merged 2 commits into
mainfrom
bugfix/noid/viewer-loading-collectives
Aug 9, 2023
Merged

fix: Properly handle viewer loading in collectives#4657
mejo- merged 2 commits into
mainfrom
bugfix/noid/viewer-loading-collectives

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Aug 9, 2023

Copy link
Copy Markdown
Member
  • Fix emitting the loaded state in all cases
  • Rework check for source based read only view to explicitly limit on versions or files with source only (without a file id)

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@cypress

cypressBot commented Aug 9, 2023

Copy link
Copy Markdown

1 flaky tests on run #11599 ↗︎

014920Flakiness1

Details:

fix: Properly handle viewer loading in collectives
Project: TextCommit:549efefc71
Status: PassedDuration: 04:22 💡
Started: Aug 9, 2023 8:17 AMEnded: Aug 9, 2023 8:21 AM
Flakiness cypress/e2e/api/SyncServiceProvider.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Sync service provider > recovers from a dropped message OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mejo-mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this!

@mejo-

mejo- commented Aug 9, 2023

Copy link
Copy Markdown
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo-
mejo- merged commit 2716cfd into mainAug 9, 2023
@mejo-
mejo- deleted the bugfix/noid/viewer-loading-collectives branch August 9, 2023 08:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@mejo-@nextcloud-command