Skip to content

fix: Sort regular smart picker options first - #4682

Merged
juliusknorr merged 2 commits into
mainfrom
fix/smartpicker-order
Aug 18, 2023
Merged

fix: Sort regular smart picker options first#4682
juliusknorr merged 2 commits into
mainfrom
fix/smartpicker-order

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Aug 14, 2023

Copy link
Copy Markdown
Member

Just reordering them as requested during the feature demo

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress

cypressBot commented Aug 14, 2023

Copy link
Copy Markdown

1 flaky tests on run #11686 ↗︎

014920Flakiness1

Details:

fix: Sort regular smart picker options first
Project: TextCommit:2abeb1f255
Status: PassedDuration: 09:01 💡
Started: Aug 14, 2023 2:18 PMEnded: Aug 14, 2023 2:27 PM
Flakiness cypress/e2e/files.spec.js • 1 flaky test

ViewOutputVideo

Test Artifacts
Text and server mimetypes > handle asciidoc as plaintext for now OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorrjuliusknorr added bug Something isn't working 3. to review labels Aug 16, 2023
@juliusknorrjuliusknorr added this to the Nextcloud 28 milestone Aug 16, 2023
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr
juliusknorr merged commit e307c8b into mainAug 18, 2023
@juliusknorr
juliusknorr deleted the fix/smartpicker-order branch August 18, 2023 08:38
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport 24ac46b to stable27

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releasebugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@luka-nextcloud@nextcloud-command