fix: Avoid layout jump with rich workspace by juliusknorr · Pull Request #4776 · nextcloud/text

juliusknorr · 2023-09-06T15:37:46Z

Alternative approach to #4254 which uses additional dav properties to already know on initial rendering if space for the rich workspace should be preserved.

In addition we can actually use the webdav markdown response to even show the full file content rendered before the text session is even started. As a follow up we could think about only initializing the session if the user clicks the rich workspace which would save us from lots of requests and problems with rich workspace always being locked.

cypress · 2023-09-06T16:00:44Z

3 failed and 2 flaky tests on run #12070 ↗︎

3	137	18	0	2

Details:

fix: Avoid layout jump with rich workspace
Project: Text	Commit:`ce0efd6f00`
Status: Failed	Duration: 05:13 💡
Started: Sep 8, 2023 8:46 PM	Ended: Sep 8, 2023 8:51 PM

cypress/e2e/attachments.spec.js • 3 failed tests

ViewOutputVideo

Test		Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file		`OutputScreenshots`
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file		`OutputScreenshots`
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side		`OutputScreenshots`

share.spec.js • 1 flaky test

ViewOutputVideo

Test		Artifacts
Open test.md in viewer > Share a file with download disabled shows an error		`OutputScreenshots`

api/SyncServiceProvider.spec.js • 1 flaky test

ViewOutputVideo

Test		Artifacts
Sync service provider > recovers from a dropped message		`OutputScreenshots`

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

juliusknorr · 2023-09-08T09:26:33Z

Will bump OCP composer package once other CI is good :)

juliusknorr · 2023-09-08T12:40:26Z

Version failures unrealted, fix in nextcloud/server#40348

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr · 2023-09-08T20:56:35Z

Remaining failures unrelated

szaimen · 2023-09-09T06:42:35Z

🎉🎉🎉🎉🎉

maximelehericy · 2023-12-04T11:19:02Z

@juliushaertl layout jumps does not occur on first page load, however, if you refresh the page or open and close an image from the viewer, layout jump still occurs.

Fixes#5332. Looks like #4698 brought back the file list header initialization that had just been moved to an init script in #4776. Signed-off-by: Max <max@nextcloud.com>

juliusknorr commented Sep 6, 2023
View reviewed changes

Comment threadsrc/helpers/files.js Outdated

juliusknorr commented Sep 6, 2023
View reviewed changes

Comment threadsrc/helpers/files.js Outdated

juliusknorr commented Sep 6, 2023
View reviewed changes

Comment threadsrc/views/RichWorkspace.vue

juliusknorr added bug Something isn't working 2. developing labels Sep 6, 2023

juliusknorr added this to the Nextcloud 28 milestone Sep 6, 2023

juliusknorr mentioned this pull request Sep 6, 2023
Prevent cumulative layout shift when rich workspace is loading #4254
Closed
3 tasks

juliusknorr force-pushed the enh/rich-workspace-switch branch from 0eb23bb to 23ce8f8Compare September 8, 2023 07:15

juliusknorr mentioned this pull request Sep 8, 2023
fix: Update file list headers on breadcrumb navigation nextcloud/server#40345
Merged
4 tasks

juliusknorrand others added 2 commits September 8, 2023 11:15

fix: Avoid layout jump with rich workspace
1852e11
Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix: move to addInitScript
bbd5d6d
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>

juliusknorr force-pushed the enh/rich-workspace-switch branch from 23ce8f8 to bbd5d6dCompare September 8, 2023 09:15

juliusknorr marked this pull request as ready for review September 8, 2023 09:25

juliusknorr requested review from luka-nextcloud, max-nextcloud, mejo- and skjnldsv September 8, 2023 09:25

juliusknorr added 3. to review and removed 2. developing labels Sep 8, 2023

skjnldsv approved these changes Sep 8, 2023
View reviewed changes

chore(deps): Bump nextcloud/ocp
e165802
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the enh/rich-workspace-switch branch from 49c1e3d to 4effe7eCompare September 8, 2023 12:56

tests: Make conflict dialog selector unique
ce0efd6
Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliusknorr force-pushed the enh/rich-workspace-switch branch from cb834be to ce0efd6Compare September 8, 2023 20:40

juliusknorr merged commit 91f9e17 into mainSep 8, 2023

juliusknorr deleted the enh/rich-workspace-switch branch September 8, 2023 20:56

juliusknorr mentioned this pull request Sep 11, 2023
[Bug]: rich workspaces makes loading jumpy, which makes fast navigation impossible nextcloud/server#39090
Closed
8 tasks

juliusknorr mentioned this pull request Nov 20, 2023
Rich workspaces takes too much screen estate when Readme.md is empty #5018
Closed

juliusknorr mentioned this pull request Dec 1, 2023
Improve read only performance when just displaying rich workspace #2183
Open

juliusknorr mentioned this pull request Dec 4, 2023
Still some layout jumps with rich workspaces #5083
Open

max-nextcloud mentioned this pull request Dec 7, 2023
layout jumps on rich workspace page refresh and viewer closed #5097
Closed

max-nextcloud added a commit that referenced this pull request Feb 2, 2024
fix: only register workspace once
6c1c67a
Fixes#5332. Looks like #4698 brought back the file list header initialization that had just been moved to an init script in #4776. Signed-off-by: Max <max@nextcloud.com>

max-nextcloud added a commit that referenced this pull request Feb 2, 2024
fix: only register workspace once
51064d9
Fixes#5332. Looks like #4698 brought back the file list header initialization that had just been moved to an init script in #4776. Signed-off-by: Max <max@nextcloud.com>

max-nextcloud mentioned this pull request Feb 2, 2024
fix: only register workspace once #5335
Merged
3 tasks

backportbotBot pushed a commit that referenced this pull request Feb 6, 2024
fix: only register workspace once
b358266
Fixes#5332. Looks like #4698 brought back the file list header initialization that had just been moved to an init script in #4776. Signed-off-by: Max <max@nextcloud.com>

Navigation Menu

Uh oh!

fix: Avoid layout jump with rich workspace - #4776

fix: Avoid layout jump with rich workspace#4776
juliusknorr merged 4 commits into
mainfrom
enh/rich-workspace-switch

juliusknorr commented Sep 6, 2023•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cypressBot commented Sep 6, 2023•
edited
Loading

Uh oh!

juliusknorr commented Sep 8, 2023

Uh oh!

juliusknorr commented Sep 8, 2023

Uh oh!

juliusknorr commented Sep 8, 2023

Uh oh!

szaimen commented Sep 9, 2023

Uh oh!

maximelehericy commented Dec 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

juliusknorr commented Sep 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cypressBot commented Sep 6, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

3 failed and 2 flaky tests on run #12070 ↗︎

Uh oh!

juliusknorr commented Sep 8, 2023

Uh oh!

juliusknorr commented Sep 8, 2023

Uh oh!

juliusknorr commented Sep 8, 2023

Uh oh!

szaimen commented Sep 9, 2023

Uh oh!

maximelehericy commented Dec 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

juliusknorr commented Sep 6, 2023•
edited
Loading

cypressBot commented Sep 6, 2023•
edited
Loading