Skip to content

fix(mention): use new url schema - #5302

Merged
juliusknorr merged 1 commit into
mainfrom
fix/404-on-mention
Jan 22, 2024
Merged

fix(mention): use new url schema#5302
juliusknorr merged 1 commit into
mainfrom
fix/404-on-mention

Conversation

@max-nextcloud

Copy link
Copy Markdown
Collaborator

📝 Summary

Fixes notifications for mentions in 28 and following.

🖼️ Screenshots

Test mentioning users -- Select a user will insert the mention (failed)

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable28

@max-nextcloudmax-nextcloud added this to the Nextcloud 29 milestone Jan 22, 2024
@max-nextcloudmax-nextcloud added tests If you write them we ♥ you 3. to review bug Something isn't working bug: regression labels Jan 22, 2024
@juliusknorr

Copy link
Copy Markdown
Member

Thanks for looking into that Max :)

@juliusknorr
juliusknorr merged commit 9a75b21 into mainJan 22, 2024
@juliusknorr
juliusknorr deleted the fix/404-on-mention branch January 22, 2024 07:34
@backportbot

Copy link
Copy Markdown

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/5302/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 711258d7c9308b51956f1193283d9bb31d644908
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5302/stable28

Error: Failed to push branch backport/5302/stable28: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliusknorr

Copy link
Copy Markdown
Member

/backport to stable28

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingtestsIf you write them we ♥ you

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-nextcloud@juliusknorr