Uh oh!
There was an error while loading. Please reload this page.
[stable28] feat: add labels to textarea elements in translate modal - #5319
Merged
Conversation
Signed-off-by: Luka Trovic <luka@nextcloud.com>
emoral435
commented
Jan 29, 2024
/compile amend/ |
emoral435
approved these changes
Jan 29, 2024
luka-nextcloud
approved these changes
Jan 29, 2024
emoral435
commented
Jan 29, 2024
Not to familiar with the text app, so if everything looks good after compiling, and after the freezes, this is perfect! Thank you @luka-nextcloud for the support for accessibility on the website 😊 |
juliusknorr
commented
Jan 29, 2024
Member
We can drop the compile commit here before merging as we have automated that part (for the stable28 branch and up) in text as a proof of concept. It will happen after the merge. |
emoral435force-pushed
the
backport/5234/stable28
branch
from
January 29, 2024 14:25
f1da10a to
1c47c4dCompareemoral435
commented
Jan 29, 2024
That's actually so cool! Is that a process that we would be able to move to the main sever repo as well 👀 haha |
juliusknorr
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #5234