Uh oh!
There was an error while loading. Please reload this page.
test(cy): use more robust selectors in file picker - #5349
Merged
Conversation
max-nextcloud
commented
Feb 4, 2024
CollaboratorAuthor
/backport to stable28 |
max-nextcloud
commented
Feb 4, 2024
CollaboratorAuthor
Requesting backport for sake of consistency. |
* Use the selectors used in server to test the files app. * Rely on semantics (`nav`, `[aria-label=...]`). Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
test/improve-cy-selectors
branch
from
February 4, 2024 07:12
d2f20b9 to
39b2862Comparejuliusknorr
approved these changes
Feb 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
nav,[aria-label=...]).🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)