Uh oh!
There was an error while loading. Please reload this page.
fix: Add alt attribute to image nodes - #5393
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
AndyScherzinger
commented
Feb 19, 2024
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/5393/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 8a3c21a0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5393/stable28Error: Failed to clone repository: Failed to clone and cache repo: Cloning into '.'... Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
juliusknorr
commented
Feb 19, 2024
/backport to stable28 |
| :alt="alt" | ||
| class="image__main" | ||
| @load="onLoaded"> | ||
| <div class="metadata"> |
There was a problem hiding this comment.
@juliushaertl maybe we should hide the span below (class="name") for a11y? meaning making it aria-hidden="true". Because it duplicates the alt tag.
📝 Summary
It seems otherwise browser would read out the full URL with screen readers. We already have the alt text as user defined description for each image so we should make use of that.