Skip to content

[stable28] fix(attachments): Don't require document session for getting attachments - #5980

Merged
mejo- merged 1 commit into
stable28from
backport/5979/stable28
Jul 2, 2024
Merged

[stable28] fix(attachments): Don't require document session for getting attachments#5980
mejo- merged 1 commit into
stable28from
backport/5979/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Jul 2, 2024

Copy link
Copy Markdown

Backport of #5979

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
backportbotBot requested review from juliusknorr and mejo-July 2, 2024 07:17
@backportbotbackportbotBot added bug Something isn't working 3. to review labels Jul 2, 2024
@backportbotbackportbotBot added this to the Nextcloud 28.0.8 milestone Jul 2, 2024
In editors with a user or share token we don't want to depend on a
document session for fetching attachments.
This fixes fetching attachments in editors without a document session
but with a user session or share token, e.g. in view mode of the
Collectives app.
Fixes: nextcloud/collectives#1201
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the backport/5979/stable28 branch from c061303 to 59ca787CompareJuly 2, 2024 08:28
@mejo-
mejo- marked this pull request as ready for review July 2, 2024 08:29
@mejo-
mejo- merged commit c488613 into stable28Jul 2, 2024
@mejo-
mejo- deleted the backport/5979/stable28 branch July 2, 2024 12:03
@AltahrimAltahrim mentioned this pull request Jul 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mejo-