Uh oh!
There was an error while loading. Please reload this page.
Fix: compute number of icons in menubar based on --default-clickable-area - #6015
Merged
Conversation
Signed-off-by: Max <max@nextcloud.com>
* The size of the icons is now based on `--default-clickable-area`. * Use `useElementSize` instead of `useResizeObserver`. * Compute the width in a `setup()` function. Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
fix/use-setup-function
branch
from
July 8, 2024 15:54
ca8cad7 to
fc02a50Comparejuliusknorr
approved these changes
Jul 8, 2024
2 tasks
mejo-
approved these changes
Jul 9, 2024
mejo-
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
vueusetools properly.useElementSizeas it's exactly what we need.useResizeObserveris overly generic.🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)