Skip to content

[stable28] Fix/toc without transaction - #6115

Closed
backportbot[bot] wants to merge 4 commits into
stable28from
backport/5893/stable28
Closed

[stable28] Fix/toc without transaction#6115
backportbot[bot] wants to merge 4 commits into
stable28from
backport/5893/stable28

Conversation

@backportbot

@backportbotbackportbotBot commented Jul 25, 2024

Copy link
Copy Markdown

Backport of #5893

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
This will trigger an update event on the editor
which in turn will trigger all update handlers.
Avoid this when not necessary.
Signed-off-by: Max <max@nextcloud.com>
The toc does not trigger a transaction anymore
and therefore there is no push to wait for either.
Also use cypress aliases and avoid deep nesting
of cypress calls when possible.
Signed-off-by: Max <max@nextcloud.com>
[skip ci]
@backportbotbackportbotBot added bug Something isn't working 3. to review labels Jul 25, 2024
@backportbotbackportbotBot added this to the Nextcloud 28.0.9 milestone Jul 25, 2024
@mejo-mejo- closed this Jul 25, 2024
@max-nextcloud

Copy link
Copy Markdown
Collaborator

@mejo- Is this not needed for stable28 or has it been backported elsewhere?

@mejo-

Copy link
Copy Markdown
Member

@max-nextcloud it got backported here: #6124

It was easier to backport from the adjusted stable29 backport.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@max-nextcloud@mejo-