Skip to content

feat(menu): Put list items in submenu, add indentation options - #6353

Merged
mejo- merged 2 commits into
mainfrom
feat/menubar_list_submenu
Sep 16, 2024
Merged

feat(menu): Put list items in submenu, add indentation options#6353
mejo- merged 2 commits into
mainfrom
feat/menubar_list_submenu

Conversation

@mejo-

@mejo-mejo- commented Sep 13, 2024

Copy link
Copy Markdown
Member

Fixes: #2438
Contributes to: #2836

🖼️ Screenshots

🏚️ Before🏡 After
imageimage
Screencast
recording1

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo-mejo- added bug Something isn't working 3. to review labels Sep 13, 2024
@mejo-mejo- added this to the Nextcloud 31 milestone Sep 13, 2024
@mejo-mejo- self-assigned this Sep 13, 2024

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Basically good to go, only 2 remarks:

  • A separator line between the list options and indentation options would be useful (as per the suggestion)

Sidenote: This change makes it more obvious that once you decide for ordered/unordered list or checklist, you can not change between them. Any specific reason for that? (But that's a different issue.

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, actually missed something: It is "indentation", not "indention". :)

(EDIT: Actually both seem to exist, but "indentation" is the more commonly used one. If we want to be short, then we can use "Increase indent" / "Decrease indent".)

Comment threadcypress/e2e/workspace.spec.js Outdated
@mejo-
mejo-force-pushed the feat/menubar_list_submenu branch from f4a4b7e to 0576d45CompareSeptember 13, 2024 13:40
@mejo-

Copy link
Copy Markdown
MemberAuthor

Sidenote: This change makes it more obvious that once you decide for ordered/unordered list or checklist, you can not change between them. Any specific reason for that? (But that's a different issue.

True, but that's another issue tracked in its own issue already. No idea so far, why this is the case.

@mejo-mejo- changed the title feat(menu): Put list items in submenu, add indention optionsfeat(menu): Put list items in submenu, add indentation optionsSep 14, 2024
@mejo-

Copy link
Copy Markdown
MemberAuthor
  • A separator line between the list options and indentation options would be useful (as per the suggestion)
  • (EDIT: Actually both seem to exist, but "indentation" is the more commonly used one. If we want to be short, then we can use "Increase indent" / "Decrease indent".)

Thanks for the review @jancborchardt. Both added now, see the updated screenshot (I didn't update the screencast) 😊

@mejo-
mejo-force-pushed the feat/menubar_list_submenu branch from 0576d45 to d6317c1CompareSeptember 14, 2024 06:33
@mejo-
mejo-force-pushed the feat/menubar_list_submenu branch 2 times, most recently from d2ff6cf to 48d0efbCompareSeptember 14, 2024 20:24
Fixes: #2438
Contributes to: #2836
Signed-off-by: Jonas <jonas@freesources.org>
Makes sure they're a continuous row from 1 to 16
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the feat/menubar_list_submenu branch from 48d0efb to 4a3b2bbCompareSeptember 16, 2024 09:31
@mejo-
mejo- merged commit 68486f8 into mainSep 16, 2024
@mejo-
mejo- deleted the feat/menubar_list_submenu branch September 16, 2024 18:07
@mejo-

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add buttons to change list indentation level

3 participants

@mejo-@jancborchardt@juliusknorr