Skip to content

Fix headings papercuts - #6404

Merged
mejo- merged 2 commits into
mainfrom
fix/headings_papercuts
Sep 16, 2024
Merged

Fix headings papercuts#6404
mejo- merged 2 commits into
mainfrom
fix/headings_papercuts

Conversation

@mejo-

@mejo-mejo- commented Sep 15, 2024

Copy link
Copy Markdown
Member

📝 Summary

Quick fixes from design feedback during conference:

  • Remove blue top border in viewer, as it doesn't look nice with open sidebar.
  • Add bottom border line to menubar. Better visual separation of menubar and editor content, especially when scrolling long content.

🖼️ Screenshots

🏚️ Before logged in🏡 After logged in
imageimage
🏚️ Before public read-only share🏡 After public read-only share
imageimage

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

It doesn't look nice with open sidebar.
Signed-off-by: Jonas <jonas@freesources.org>
Better visual separation of menubar and editor content, especially when
scrolling long content.
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-mejo- added this to the Nextcloud 31 milestone Sep 15, 2024
@mejo-mejo- self-assigned this Sep 15, 2024
@mejo-

Copy link
Copy Markdown
MemberAuthor

/backport to stable30

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Thanks for the feedback as well @bentuna!

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Thanks for the feedback as well @bentuna!

@mejo-
mejo-force-pushed the fix/headings_papercuts branch from 7441a0a to 90696a2CompareSeptember 15, 2024 15:48
@mejo-
mejo- merged commit c48d7ff into mainSep 16, 2024
@mejo-
mejo- deleted the fix/headings_papercuts branch September 16, 2024 08:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingdesign: papercut

Projects

Archived in project
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants

@mejo-@jancborchardt@susnux@max-nextcloud