Uh oh!
There was an error while loading. Please reload this page.
[stable29] fix(paragraph): migrate preview options to decorations - #6430
Merged
Conversation
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Render the preview options as a decoration for previews too. Signed-off-by: Max <max@nextcloud.com>
Fixes: #6185 Signed-off-by: Jonas <jonas@freesources.org>
mejo-force-pushed
the
backport/6425/stable29
branch
from
September 23, 2024 11:37
7e94025 to
5c22e5bComparemejo-
marked this pull request as ready for review
September 23, 2024 11:38
mejo-
approved these changes
Sep 23, 2024
Signed-off-by: Jonas <jonas@freesources.org>
Required for implementing `deleteNode` like tiptap does it: https://github.com/ueberdosis/tiptap/blob/develop/packages/core/src/NodeView.ts#L305 Signed-off-by: Max <max@nextcloud.com>
Compute the range based on offset and nodeSize. Signed-off-by: Max <max@nextcloud.com>
- center align options for text links - top align options for preview links Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Otherwise the overlay container would catch all the click events. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
* Don't calculate preview options decorations in readonly editor * Check for changed nodeSize when checking for decoration changes * Rename `editor` to `$editor` in vue compontent, it's not reactive Signed-off-by: Jonas <jonas@freesources.org>
mejo-force-pushed
the
backport/6425/stable29
branch
from
September 23, 2024 13:32
5c22e5b to
42960f7Compare2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6425