Uh oh!
There was an error while loading. Please reload this page.
refactor(EditorFactory): split createEditor in rich and plain variant - #6505
Closed
max-nextcloud wants to merge 2 commits into
Closed
refactor(EditorFactory): split createEditor in rich and plain variant#6505max-nextcloud wants to merge 2 commits into
max-nextcloud wants to merge 2 commits into
Conversation
Use two functions that do one thing rather than one with a boolean flag. Simplifies the functions use and signature a lot in particular since plain and rich editor need different arguments. Signed-off-by: Max <max@nextcloud.com>
This does not require jsdoc comments. Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
refactor/split-createEditor
branch
from
October 8, 2024 07:57
a87e233 to
f724894Comparemax-nextcloud
commented
Oct 8, 2024
CollaboratorAuthor
Cypress failures in assistant and version tests are known and unrelated. |
max-nextcloud
commented
Oct 8, 2024
CollaboratorAuthor
Superseeded by #6507 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use two functions that do one thing
rather than one with a boolean flag.
Simplifies the functions use and signature a lot
in particular since plain and rich editor need different arguments.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)