Skip to content

Show link url in popover - #687

Closed
juliusknorr wants to merge 1 commit into
masterfrom
bugfix/noid/link-popover
Closed

Show link url in popover#687
juliusknorr wants to merge 1 commit into
masterfrom
bugfix/noid/link-popover

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Feb 25, 2020

Copy link
Copy Markdown
Member

Make sure that the link is not directly opened but presented to the user to avoid that someone might get tricked into clicking a link that opens some unwanted page.

Currently even hovering the link is not working to preview it as this is prevented by browsers if contenteditable is set to true.

Requires ueberdosis/tiptap#614

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@cypress

cypressBot commented Feb 25, 2020

Copy link
Copy Markdown



Test summary

12000


Run details

Projecttext
StatusPassed
Commit3441307
StartedFeb 25, 2020 3:14 PM
EndedFeb 25, 2020 3:15 PM
Duration00:53 💡
OSLinux Ubuntu Linux - 18.04
BrowserElectron 78

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@juliusknorrjuliusknorr mentioned this pull request Jun 16, 2020
@skjnldsv
skjnldsv deleted the bugfix/noid/link-popover branch March 13, 2024 06:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingbugSomething isn't workingupstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusknorr