Skip to content

feat: Implement event so collectives can inject custom notification messages - #6923

Merged
mejo- merged 1 commit into
mainfrom
feat/custom-mention
May 13, 2025
Merged

feat: Implement event so collectives can inject custom notification messages#6923
mejo- merged 1 commit into
mainfrom
feat/custom-mention

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Feb 27, 2025

Copy link
Copy Markdown
Member

Base pr for nextcloud/collectives#1675 to allow the collectives app to set their own notification details for mentions within a collective.

@max-nextcloudmax-nextcloud left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. Makes sense to have this. did not test it though.

... which also reminds me that it might be nice to have tests for this as it will be hard to notice if it breaks.

…essages
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@mejo-
mejo-force-pushed the feat/custom-mention branch from 04283a2 to df8fe6eCompareMay 13, 2025 11:21

@mejo-mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works well! I guess the easiest would be to test this inside Collectives tbh.

@mejo-
mejo- merged commit e88ee52 into mainMay 13, 2025
@mejo-
mejo- deleted the feat/custom-mention branch May 13, 2025 11:38
@mejo-

Copy link
Copy Markdown
Member

/backport to stable31

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@mejo-@max-nextcloud