Uh oh!
There was an error while loading. Please reload this page.
fix: Avoid pushing empty messages - #6937
Merged
Merged
Conversation
Signed-off-by: Julius Knorr <jus@bitgrid.net>
max-nextcloud
approved these changes
Mar 15, 2025
max-nextcloud
commented
Mar 15, 2025
Collaborator
/backport to stable31 |
max-nextcloud
commented
Mar 15, 2025
Collaborator
Good catch!! I don't know if these are expected off the top of my head. I think we still store the awareness messages in the session data. That might cause an empty string if no awareness has ever been send from the users but the session still exists. Would be good to clean up the awareness handling. I'll create a follow up issue. |
max-nextcloud
commented
Mar 15, 2025
Collaborator
/backport to stable30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in sentry
Fixes a regular js console error when using notify_push where the awareness message may be pushed as empty string.
We avoid this filtering on the backend before we emit the messages over notify_push, but @max-nextcloud do you happen to know if seeing those empty awareness messages being pushed is expected?
Without this PR parsing the empty data fails in
text/src/services/y-websocket.js
Line 167 in ed57736