Skip to content

[stable31] Keep layout on sync errors - #6944

Merged
juliusknorr merged 12 commits into
stable31from
backport/6903/stable31
Mar 13, 2025
Merged

[stable31] Keep layout on sync errors#6944
juliusknorr merged 12 commits into
stable31from
backport/6903/stable31

Conversation

@backportbot

Copy link
Copy Markdown

Backport of PR #6903

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
The document status div is full width.
Its background hides the text behind it and scrollbars on the side.
Introduce a new .status-wrapper div that sets the background
and only has the size of the actual message.
Also move the message to the very bottom of the screen on mobile.
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Otherwise unpacking the tar file failed on github runners
if the cache was created by garm runners
and the binary could not be found on garm runners
if the cache was created by github runners.
Signed-off-by: Max <max@nextcloud.com>
@backportbotbackportbotBot added bug Something isn't working 3. to review labels Mar 12, 2025
@backportbotbackportbotBot added this to the Nextcloud 31.0.1 milestone Mar 12, 2025
@codecov

codecovBot commented Mar 12, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 76.84211% with 22 lines in your changes missing coverage. Please review.

Project coverage is 47.38%. Comparing base (4c7fbff) to head (f2ff59d).
Report is 14 commits behind head on stable31.

Files with missing linesPatch %Lines
src/components/Editor/DocumentStatus.vue0.00%12 Missing ⚠️
...rc/components/Editor/DocumentStatus/SyncStatus.vue91.25%6 Missing and 1 partial ⚠️
src/components/Editor.vue0.00%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## stable31 #6944 +/- ##
============================================
+ Coverage 46.51% 47.38% +0.87% 
============================================
Files 751 742 -9 Lines 34651 34700 +49 Branches 1270 1276 +6 ============================================
+ Hits 16118 16444 +326 + Misses 17910 17645 -265 + Partials 623 611 -12 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Max <max@nextcloud.com>
…table31
[backport/6903/stable31] fix(reuse): add license info for vitest snapshots
@juliusknorr
juliusknorr merged commit b363236 into stable31Mar 13, 2025
@juliusknorr
juliusknorr deleted the backport/6903/stable31 branch March 13, 2025 20:49
@AltahrimAltahrim mentioned this pull request Mar 18, 2025
20 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@blizzz@max-nextcloud