Uh oh!
There was an error while loading. Please reload this page.
Fix flaky cypress tests - #6965
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #6965 +/- ##
=======================================
Coverage 51.82% 51.82% =======================================
Files 476 476 Lines 40154 40154 Branches 985 985 =======================================
Hits 20811 20811 Misses 19237 19237 Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorrforce-pushed
the
tests/cypress-green
branch
from
March 17, 2025 21:42
8470701 to
1340a21CompareSigned-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorrforce-pushed
the
tests/cypress-green
branch
from
March 17, 2025 22:15
223fbe6 to
3210385Comparejuliusknorr
commented
Mar 17, 2025
| .click() | ||
| // eslint-disable-next-line cypress/no-unnecessary-waiting | ||
| cy.wait(1000) |
MemberAuthor
There was a problem hiding this comment.
I did not figure out a way to make this wort otherwise. For some reason running on CI otherwise focusses the NcSelect 🤷
juliusknorr
commented
Mar 17, 2025
MemberAuthor
/backport to stable31 |
juliusknorr
commented
Mar 17, 2025
MemberAuthor
/backport to stable30 |
juliusknorr
commented
Mar 17, 2025
MemberAuthor
/backport to stable29 |
This was referenced Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runner 1 Assistant - Open translate dialog
Otherwise this test is flaky as it may not focus fast enough before entering text, also clicking my interfere with the autofocus of the language selection. Certainly the test could be improved but this is a quick fix to get back to green ci
runner 7 The session Api - signals closing connection
The issue is that the close api call was not awaited properly. This lead to situations where the push was called too early. Can be tested locally with adding a sleep on the backend in https://github.com/nextcloud/text/blob/tests/cypress-green/lib/Service/ApiService.php#L161