Uh oh!
There was an error while loading. Please reload this page.
[stable31] Fix: writing during short connection failures - #7096
Merged
Conversation
Allow changing a flag with different delays:
* Switch it on slow.
* Switch it off fast.
Useful for errors - so they only show after a while but are resolved quickly.
Example:
const input = ref(false)
const { delayed } = useDelayedFlag(input)
...
input.value = true
// 5 seconds later delayed.value will be true
...
input.value = false
// 200 ms later delayed.value will be true
Signed-off-by: Max <max@nextcloud.com>max-nextcloudforce-pushed
the
backport/7093/stable31
branch
from
April 11, 2025 08:53
dc7029b to
94c5ff4Comparemax-nextcloud
marked this pull request as ready for review
April 11, 2025 08:53
max-nextcloud
approved these changes
Apr 11, 2025
Delay the error message and allow editing for 5 seconds. Also speed up the recovery by triggering push after a successful sync. Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
backport/7093/stable31
branch
from
April 11, 2025 08:55
94c5ff4 to
a133584Comparemax-nextcloud
approved these changes
Apr 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## stable31 #7096 +/- ##
============================================
+ Coverage 52.01% 52.04% +0.02%
============================================
Files 286 287 +1 Lines 40675 40698 +23 Branches 789 794 +5 ============================================
+ Hits 21159 21182 +23
Misses 19395 19395 Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7093
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.