Uh oh!
There was an error while loading. Please reload this page.
Refactor document status and menubar padding - #7130
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #7130 +/- ##
==========================================
+ Coverage 51.83% 51.85% +0.02%
==========================================
Files 479 479 Lines 41488 41510 +22 Branches 1002 1002 ==========================================
+ Hits 21504 21526 +22
Misses 19879 19879 Partials 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mejo-force-pushed
the
fix/refactor_document_status
branch
from
April 16, 2025 11:42
0ff0401 to
8d43fb1Comparemejo-
commented
Apr 16, 2025
MemberAuthor
/backport to stable31 |
mejo-force-pushed
the
fix/refactor_document_status
branch
from
April 29, 2025 12:47
8d43fb1 to
cc5fef4CompareMove DocumentStatus into parent container to do so. Fixes stickyness of document status if editor does not have the full app content height, e.g. in Collectives or Deck. Signed-off-by: Jonas <jonas@freesources.org>
Fixes stickyness of menubar when editor does not have the full app height, e.g. in Collectives and Deck. Fixes: nextcloud/collectives#1704 Signed-off-by: Jonas <jonas@freesources.org>
mejo-force-pushed
the
fix/refactor_document_status
branch
from
April 29, 2025 12:48
cc5fef4 to
e7d5527CompareSigned-off-by: Jonas <jonas@freesources.org>
Fixes "[Vue warn]: Property or method "lock" is not defined on the instance but referenced during render." Signed-off-by: Jonas <jonas@freesources.org>
Make sure that document status and collision resolve dialog stay visible when scrolling down long documents. Signed-off-by: Jonas <jonas@freesources.org>
mejo-force-pushed
the
fix/refactor_document_status
branch
from
April 29, 2025 12:54
e7d5527 to
e270905Compare…overflow Signed-off-by: Jonas <jonas@freesources.org>
MemberAuthor
I again did extensive testing to find possible regressions and added another fix concerning mobile view with menubar at the bottom. This is the test matrix I went through: ✔️ = no problems
|
max-nextcloud
commented
Apr 30, 2025
Collaborator
Scrollbar on mobileI'm now seeing a scrollbar on short documents in chromium and if a message is displayed the scrollable area becomes higher: Bildschirmaufzeichnung.vom.2025-04-30.08-56-34.mp4Positioning on standalone (Chromium)(Not sure this is an issue...)
|
Use flexbox layout instead of height `100%` to avoid issues where editor is embedded into other apps and doesn't take full height. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
We want the border to separate document content and menubar. So when we display the menubar at the bottom on mobile, the menubar border should be on top, not bottom of it. Signed-off-by: Jonas <jonas@freesources.org>
I spent some time trying to figure out where the extra 8px came from that created the scrollbar even with short content on mobile. In the end this seems like an acceptable workaround for now. Signed-off-by: Jonas <jonas@freesources.org>
mejo-force-pushed
the
fix/refactor_document_status
branch
from
April 30, 2025 11:55
a6c93ef to
87f2ddfComparemejo-
commented
Apr 30, 2025
MemberAuthor
Fixed this by using flexbox layout and
Both also fixed now. |
max-nextcloud
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
lockto data🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)