Skip to content

feat(link): Toggle link on selection with Mod-K shortcut - #7188

Merged
mejo- merged 1 commit into
mainfrom
feat/link_shortcut
May 8, 2025
Merged

feat(link): Toggle link on selection with Mod-K shortcut#7188
mejo- merged 1 commit into
mainfrom
feat/link_shortcut

Conversation

@mejo-

@mejo-mejo- commented May 6, 2025

Copy link
Copy Markdown
Member

Acts only upon selection as inserting a link with empty title creates an invisible link, resulting in bad user experience in the WYSIWYG editor.

Fixes: #7152

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

Acts only upon selection as inserting a link with empty title creates an
invisible link, resulting in bad user experience in the WYSIWYG editor.
Fixes: #7152
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-mejo- self-assigned this May 6, 2025
@mejo-
mejo- requested a review from max-nextcloud as a code ownerMay 6, 2025 11:19
@github-project-automationgithub-project-automationBot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity teamMay 6, 2025
@mejo-mejo- added the enhancement New feature or request label May 6, 2025
@mejo-mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity teamMay 6, 2025
@mejo-

mejo- commented May 6, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@codecov

codecovBot commented May 6, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 38.70968% with 19 lines in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (bf3594e) to head (f16579a).
Report is 28 commits behind head on main.

Files with missing linesPatch %Lines
src/components/Link/LinkBubbleView.vue0.00%12 Missing ⚠️
src/marks/Link.js46.15%7 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #7188 +/- ##
==========================================
+ Coverage 52.41% 52.51% +0.10% 
==========================================
Files 479 479 Lines 41508 41545 +37 Branches 1024 1024 ==========================================
+ Hits 21757 21819 +62 + Misses 19649 19624 -25 
Partials 102 102 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luka-nextcloud

Copy link
Copy Markdown
Contributor

I've tested and it works well 👍

@mejo-
mejo- merged commit c25cefd into mainMay 8, 2025
@mejo-
mejo- deleted the feat/link_shortcut branch May 8, 2025 08:39
@github-project-automationgithub-project-automationBot moved this from 👀 In review to ☑️ Done in 📝 Productivity teamMay 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewenhancementNew feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Ctrl-K should add a link to highlighted text

2 participants

@mejo-@luka-nextcloud