Uh oh!
There was an error while loading. Please reload this page.
fix(files): Add smooth animation via clicking on heading - #7197
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #7197 +/- ##
==========================================
+ Coverage 51.85% 58.97% +7.12%
==========================================
Files 479 482 +3 Lines 41580 37117 -4463 Branches 1002 1048 +46 ==========================================
+ Hits 21561 21891 +330 + Misses 19914 15124 -4790 + Partials 105 102 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5944b1a to
7ebc209Compare
max-nextcloud
left a comment
There was a problem hiding this comment.
Tested locally and works for me. Code changes also seem fine.
mejo-
commented
May 8, 2025
Mhh, interesting. For me, this PR breaks anchor links. Whenever I click on the |
mejo-
commented
May 8, 2025
It doesn't scroll back to the top of the document, but scrolls the clicked heading into the middle of the screen if possible. I guess that's a bit counter-intuitive and I would expect the heading to scrolled to the top of the editor container. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
8c8b55b to
dce5bd5CompareJuliaKirschenheuter
commented
Jun 16, 2025
@mejo- Hi Jonas, could you please look into this again? Thank you! |
Uh oh!
There was an error while loading. Please reload this page.
dce5bd5 to
1ade190Comparemejo-
commented
Jun 18, 2025
/backport to stable31 |
mejo-
commented
Jun 18, 2025
/backport to stable30 |
mejo-
left a comment
There was a problem hiding this comment.
Prettier complains about prosemirror.css. Once this got resolved, it's ready to merge 😊
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
1ade190 to
f754128Comparemejo-
commented
Jun 20, 2025
The failing assistant cypress test seems unrelated. It also fails on other PRs. |
📝 Summary
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)