Skip to content

[stable31] Bring back and refactor keymap, add focus trap to plain text editor - #7242

Merged
mejo- merged 12 commits into
stable31from
backport/7204/stable31
May 21, 2025
Merged

[stable31] Bring back and refactor keymap, add focus trap to plain text editor#7242
mejo- merged 12 commits into
stable31from
backport/7204/stable31

Conversation

@backportbot

@backportbotbackportbotBot commented May 21, 2025

Copy link
Copy Markdown

Backport of #7204

@backportbotbackportbotBot added this to the Nextcloud 31.0.6 milestone May 21, 2025
mejo- added 2 commits May 21, 2025 12:16
Signed-off-by: Jonas <jonas@freesources.org>
The keymap extension was not in use for quite some time and I'm now
longer able to reproduce issues with <Mod>-<F> without the overwrite
either.
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the backport/7204/stable31 branch from 8b2f002 to 9d0c2dfCompareMay 21, 2025 10:28
mejo- added 6 commits May 21, 2025 12:30
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the backport/7204/stable31 branch from 9d0c2df to c796eb1CompareMay 21, 2025 10:30
@codecov

codecovBot commented May 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 85.41667% with 28 lines in your changes missing coverage. Please review.

Project coverage is 59.28%. Comparing base (15f2e7f) to head (514b4f8).
Report is 13 commits behind head on stable31.

Files with missing linesPatch %Lines
src/nodes/CodeBlock/codeBlockShortcuts.js59.57%19 Missing ⚠️
src/extensions/Keymap.js84.31%8 Missing ⚠️
src/components/PlainTextReader.vue0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## stable31 #7242 +/- ##
============================================
+ Coverage 52.20% 59.28% +7.07% 
============================================
Files 286 287 +1 Lines 40798 36131 -4667 Branches 817 835 +18 ============================================
+ Hits 21300 21420 +120 + Misses 19382 14596 -4786 + Partials 116 115 -1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mejo- added 4 commits May 21, 2025 12:36
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the backport/7204/stable31 branch from c796eb1 to 514b4f8CompareMay 21, 2025 10:36
@mejo-
mejo- marked this pull request as ready for review May 21, 2025 10:37
@mejo-
mejo- enabled auto-merge May 21, 2025 10:37
@mejo-
mejo- merged commit ac615d8 into stable31May 21, 2025
@mejo-
mejo- deleted the backport/7204/stable31 branch May 21, 2025 10:46
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2025
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingtechnical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mejo-