Uh oh!
There was an error while loading. Please reload this page.
fix/out of sync - #7377
Merged
Merged
Conversation
max-nextcloud
commented
Jun 30, 2025
Collaborator
- chore(debug): log pending structs in remote ydoc
- fix(sync): check pending structs and resync if needed
- fix(sync): send SyncStep1 right after step could not be applied
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #7377 +/- ##
==========================================
- Coverage 52.68% 52.67% -0.02%
==========================================
Files 487 487 Lines 42217 42237 +20 Branches 1098 1098 ==========================================
+ Hits 22243 22247 +4 - Misses 19867 19883 +16
Partials 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloudforce-pushed
the
fix/out-of-sync
branch
2 times, most recently
from
June 30, 2025 17:10
cfe813f to
10337a2Comparemejo-
approved these changes
Jun 30, 2025
mejo-
left a comment
Member
There was a problem hiding this comment.
I have two comments/questions. Otherwise code changes look good to me 🎉
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
max-nextcloud
commented
Jul 1, 2025
CollaboratorAuthor
/backport! to stable31 |
3 tasks
max-nextcloudforce-pushed
the
fix/out-of-sync
branch
2 times, most recently
from
July 1, 2025 09:46
3294a63 to
7433473CompareThis ydoc tracks the messages already received from the server. So missing messages will also lead to pendingStructs there. Signed-off-by: Max <max@nextcloud.com>
This check will happen every 30 seconds by default. So on average it will take 15 seconds after missing a message. This is also in "sync" with new autosaved versions becoming available roughly every 30 seconds. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
fix/out-of-sync
branch
from
July 1, 2025 09:50
7433473 to
842f861CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.