Uh oh!
There was an error while loading. Please reload this page.
fix(SaveService): Don't save if yjs reports pendingStructs - #7704
Closed
mejo- wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mejo-force-pushed
the
fix/no_autosave_pending_structs
branch
from
October 1, 2025 12:39
19a67fe to
d437604CompareYjs pendingStructs most likely mean that the local yjs document state is missing a step. So let's not autosave such an inconstent state to the server. Signed-off-by: Jonas <jonas@freesources.org>
mejo-force-pushed
the
fix/no_autosave_pending_structs
branch
from
October 1, 2025 13:32
d437604 to
28ee3e7Compare4 tasks
max-nextcloud
commented
Oct 9, 2025
Collaborator
Waiting for the outcome of our attempts to prevent out of sync state and thus pending structs in the first place. |
mejo-
commented
Mar 18, 2026
MemberAuthor
@max-nextcloud I'd say let's close this PR for now as the situation seems to have improved via other changes. What do you think? |
mejo-
commented
Apr 24, 2026
MemberAuthor
Let's close this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yjs pendingStructs mean that the local yjs document state is missing a step. So let's not allow to save such an inconstent state to the server.
Screenshot
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)