Uh oh!
There was an error while loading. Please reload this page.
Fix broken syntax highlight with highlight.js > 9.16 - #775
Conversation
juliusknorr
commented
Apr 20, 2020
/backport to stable18 |
juliusknorr
commented
Apr 20, 2020
/compile /js |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
18d50f9 to
300c7efCompareTest summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
skjnldsv
commented
Apr 22, 2020
Is it known on the Highlight library? |
juliusknorr
commented
Apr 22, 2020
It is the CodeBlockHighlight component in tiptap that seems to be not compatible yet, but didn't have time yet to investigate further. |
The backport to stable18 failed. Please do this backport manually. |
| "@nextcloud/vue": "^1.5.0", | ||
| "escape-html": "^1.0.3", | ||
| "highlight.js": "^9.18.0", | ||
| "highlight.js": "^9.16.2", |
There was a problem hiding this comment.
If the problem is in highlight.js > 9.16, shouldn't the version be specified as < 9.17 instead? ^ also includes minor release updates, so next time that dependabot runs it will try to update highlight.js again to 9.18.x. Or am I missing something? :-)
There was a problem hiding this comment.
Just that I'd like dependabot to bug me about the version 😉 Also we have the package lock comitted, so the version there will be used when installing with npm ci.
There was a problem hiding this comment.
Just that I'd like dependabot to bug me about the version 😉
Hehe, fair enough ;-)
juliusknorr
commented
Apr 23, 2020
/backport 35b2f07 to stable18 |
backport to stable18 in #782 with conflicts |
Fixes#771#320