Skip to content

Remove unused preview plugin - #776

Merged
juliusknorr merged 2 commits into
masterfrom
techdebt/remove-usused-preview
Apr 20, 2020
Merged

Remove unused preview plugin#776
juliusknorr merged 2 commits into
masterfrom
techdebt/remove-usused-preview

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

The files app does no longer support javascript based preview plugins since Nextcloud 18

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/compile /js

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@cypress

cypressBot commented Apr 20, 2020

Copy link
Copy Markdown



Test summary

11100


Run details

Projecttext
StatusFailed
Commit6ad8424
StartedApr 20, 2020 10:26 AM
EndedApr 20, 2020 10:28 AM
Duration01:34 💡
OSLinux Ubuntu Linux - 18.04
BrowserElectron 78

View run in Cypress Dashboard ➡️


Failures

cypress/integration/viewer.spec.js Failed
1 Open test.md in viewer > Open the viewer on file click

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@skjnldsv

skjnldsv commented Apr 20, 2020

Copy link
Copy Markdown
Member

Icon changed
CypressError: Timed out retrying: Expected to find element: '#viewer-content .modal-header button.icon-menu-sidebar-white-forced', but never found it.

button.icon-info-white-forced

I wondered if we should create some dedicated functions in a library so it's easier to use? I feel like just using css rules that are duplicate seems a bit weird 🤔

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

Yep, that is fixed in a separate PR.

I think we could even drop that test as for text it should be fine to assume that the viewer does its stuff properly, however I added a case for it back then since we were the only app integrating at that point in time.

@juliusknorr
juliusknorr merged commit 8463df8 into masterApr 20, 2020
@juliusknorr
juliusknorr deleted the techdebt/remove-usused-preview branch April 20, 2020 10:53
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable18 failed. Please do this backport manually.

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport 35b2f07 to stable18

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable18 in #783 with conflicts ⚠️

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport 69e0eca to stable18

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable18 failed. Please do this backport manually.

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport 69e0eca to stable18

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable18 in #784 with conflicts ⚠️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@juliusknorr@skjnldsv