Skip to content

fix(PreviewOptions): Move three-dot menu into preview box or link bubble - #7793

Merged
mejo- merged 1 commit into
mainfrom
fix/link_preview_options
Oct 21, 2025
Merged

fix(PreviewOptions): Move three-dot menu into preview box or link bubble#7793
mejo- merged 1 commit into
mainfrom
fix/link_preview_options

Conversation

@mejo-

@mejo-mejo- commented Oct 16, 2025

Copy link
Copy Markdown
Member

Fixes several UX bugs that stem from the existence of the three-dot menu for link preview options. It also will allow us to move drag handle and smart picker link closer to the editor container.

Contributes to #7272

Also fixes the bug that the link is displayed above the preview in read-only view in Collectives.

🖼️ Screenshots

🏚️ Before🏡 After
imageimage
imageimage
imageimage
imageimage

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@codecov

codecovBot commented Oct 16, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.73469% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.90%. Comparing base (5bf0fc9) to head (d142d24).
⚠️ Report is 2 commits behind head on main.

Files with missing linesPatch %Lines
src/nodes/Preview.vue17.39%19 Missing ⚠️
src/components/Editor/PreviewOptions.vue52.63%9 Missing ⚠️
src/components/Link/LinkBubbleView.vue50.00%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #7793 +/- ##
==========================================
+ Coverage 53.34% 59.90% +6.55% 
==========================================
Files 503 500 -3 Lines 43534 38345 -5189 Branches 1135 1091 -44 ==========================================
- Hits 23225 22971 -254 + Misses 20202 15269 -4933 + Partials 107 105 -2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjaminfrueh
benjaminfrueh self-requested a review October 21, 2025 09:51
* Fixes: #6814 (broken alignment of preview options in lists)
* Fixes: #7693 (preview options displayed in read-only documents)
* Fixes: nextcloud/collectives#1920 (hidden preview options on narrow screens)
Also fixes the bug that the link is displayed above the preview in
read-only view in Collectives.
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-

Copy link
Copy Markdown
MemberAuthor

One minor issue, when the Link title is long, it is very difficult to click the three dot menu. It only works in a tiny area at the very top-right corner, because this is positioned absolute and behind the title. If this three-dot would have a higher z-index here, then this would also feel good to click.

Great catch! Updated now and I also added a background-color so the button is more visible.

@mejo-
mejo-force-pushed the fix/link_preview_options branch from 1163b5f to d142d24CompareOctober 21, 2025 13:43
Comment threadsrc/nodes/Preview.vue
@mejo-
mejo- merged commit 8899fef into mainOct 21, 2025
60 of 64 checks passed
@mejo-
mejo- deleted the fix/link_preview_options branch October 21, 2025 14:01
@mejo-

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingfeature: linksux

Projects

None yet

3 participants

@mejo-@marcoambrosini@benjaminfrueh