Uh oh!
There was an error while loading. Please reload this page.
[stable32] fix(FloatingButtons): group smartpicker button and drag handle together - #7827
Merged
Conversation
backportbotBot
requested review from
benjaminfrueh, juliusknorr and marcoambrosiniOctober 23, 2025 21:07
mejo-
approved these changes
Oct 23, 2025
- The button group follows the cursor now - The button group is top-aligned to hovered paragraph node - The drag handle button has cursor type `grab` - Not displayed on mobile and full width view Also removes block margin from link previews. We already have margin between paragraphs and it makes the floating buttons look off otherwise. Fixes: #7272Fixes: #7604 Signed-off-by: Jonas <jonas@freesources.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## stable32 #7827 +/- ##
============================================
- Coverage 59.80% 59.73% -0.07%
============================================
Files 500 499 -1 Lines 38464 38370 -94 Branches 1091 1061 -30 ============================================
- Hits 23003 22920 -83 + Misses 15355 15344 -11
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #7818