Skip to content

fix(LinkBubbleView): Don't choke on invalid URLs - #7864

Merged
mejo- merged 1 commit into
mainfrom
fix/unsupported_link_urls
Oct 27, 2025
Merged

fix(LinkBubbleView): Don't choke on invalid URLs#7864
mejo- merged 1 commit into
mainfrom
fix/unsupported_link_urls

Conversation

@mejo-

Copy link
Copy Markdown
Member

Fixes "TypeError: URL constructor: ... is not a valid URL."

Fixes: #6841

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

Fixes "TypeError: URL constructor: ... is not a valid URL."
Fixes: #6841
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-mejo- self-assigned this Oct 27, 2025
@mejo-mejo- added bug Something isn't working 3. to review feature: links labels Oct 27, 2025
@mejo-

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

@codecov

codecovBot commented Oct 27, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.67%. Comparing base (a0fa51b) to head (24aa144).
⚠️ Report is 6 commits behind head on main.

Files with missing linesPatch %Lines
src/components/Link/LinkBubbleView.vue41.66%4 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #7864 +/- ##
==========================================
+ Coverage 52.86% 59.67% +6.80% 
==========================================
Files 501 500 -1 Lines 43354 38411 -4943 Branches 1063 1064 +1 ==========================================
+ Hits 22918 22920 +2 + Misses 20329 15383 -4946 - Partials 107 108 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mejo-
mejo- merged commit 8595175 into mainOct 27, 2025
62 of 64 checks passed
@mejo-
mejo- deleted the fix/unsupported_link_urls branch October 27, 2025 20:38
@mejo-

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@kousu

kousu commented Nov 2, 2025

Copy link
Copy Markdown

Thanks for squashing this!!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingfeature: links

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mangled Links disable Text

3 participants

@mejo-@kousu@benjaminfrueh