Skip to content

fix(TextDirection): Skip composition transactions - #7981

Merged
mejo- merged 2 commits into
mainfrom
fix/ime_first_character
Nov 25, 2025
Merged

fix(TextDirection): Skip composition transactions#7981
mejo- merged 2 commits into
mainfrom
fix/ime_first_character

Conversation

@mejo-

Copy link
Copy Markdown
Member

Without this fix, inserting a CJK character via IME as first character in a new paragraph is broken as the composition key is inserted straight away.

Fixes: #7789

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo-mejo- self-assigned this Nov 25, 2025
@mejo-mejo- added bug Something isn't working 3. to review regression labels Nov 25, 2025
Without this fix, inserting a CJK character via IME as first character
in a new paragraph is broken as the composition key is inserted straight
away.
Fixes: #7789
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the fix/ime_first_character branch from c05be3a to 3f45427CompareNovember 25, 2025 15:16
…acter
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo-force-pushed the fix/ime_first_character branch from 3f45427 to 7539fa1CompareNovember 25, 2025 15:18
@codecov

codecovBot commented Nov 25, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment threadplaywright/e2e/ime-input.spec.ts
@mejo-
mejo- merged commit 80309b0 into mainNov 25, 2025
75 of 77 checks passed
@mejo-
mejo- deleted the fix/ime_first_character branch November 25, 2025 15:48
@mejo-

Copy link
Copy Markdown
MemberAuthor

/backport e9212e7 to stable32

@mejo-

Copy link
Copy Markdown
MemberAuthor

/backport e9212e7 to stable31

@juliusknorr

Copy link
Copy Markdown
Member

Nice, thanks for checking further

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't workingregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: First character is duplicated when typing Japanese with IME

3 participants

@mejo-@juliusknorr@max-nextcloud