Uh oh!
There was an error while loading. Please reload this page.
fix(FloatingButtons): Add missing aria-label to NcButton components - #8032
Merged
Conversation
Fixes: #8031 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
commented
Dec 10, 2025
MemberAuthor
/backport to stable32 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
max-nextcloud
commented
Dec 12, 2025
Collaborator
I tried to reproduce the problem in main branch but could not see the warnings so could not test this. |
susnux
approved these changes
Dec 12, 2025
susnux
commented
Dec 12, 2025
Contributor
@max-nextcloud the funny thing is I did not see this in the text app but in the tables app which seems to have a text integration? |
susnux
commented
Dec 12, 2025
Contributor
(anyways missing aria labels when there is no visual text are always a reason to fail WCAG so good that this is fixed now :) ) |
Uh oh!
There was an error while loading. Please reload this page.
mejo-
commented
Dec 13, 2025
MemberAuthor
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8031
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)