Skip to content

Also translate 'Add notes, ...' inside Editor - #852

Merged
juliusknorr merged 2 commits into
masterfrom
bugfix/627/missing_translation
Jun 8, 2020
Merged

Also translate 'Add notes, ...' inside Editor#852
juliusknorr merged 2 commits into
masterfrom
bugfix/627/missing_translation

Conversation

@georgehrke

Copy link
Copy Markdown
Member

Signed-off-by: Georg Ehrke developer@georgehrke.com

Summary

To test this:

  • Create a new directory
  • The "Add notes, lists or links …" is translated (1)
  • Click on the text (it creates the README.md)
  • leave directory and enter it again
  • The "Add notes, lists or links …" is not translated (2)

(1) is coming from

{{ t('text', 'Add notes, lists or links …') }}

(2) is coming from

emptyNodeText: 'Add notes, lists or links …',

@georgehrke

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the bugfix/627/missing_translation branch from eda6ea6 to 4b0b957CompareJune 5, 2020 09:54
@juliusknorr

Copy link
Copy Markdown
Member

@georgehrke Mind to rebase 🙈

@juliusknorrjuliusknorr added 4. to release bug Something isn't working and removed 3. to review labels Jun 8, 2020
@georgehrke
georgehrkeforce-pushed the bugfix/627/missing_translation branch from 4b0b957 to eda6ea6CompareJune 8, 2020 17:07
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
georgehrkeforce-pushed the bugfix/627/missing_translation branch from eda6ea6 to c517496CompareJune 8, 2020 17:10
@georgehrke

Copy link
Copy Markdown
MemberAuthor

/compile /

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@juliusknorr
juliusknorr merged commit b9f3e6d into masterJun 8, 2020
@juliusknorr
juliusknorr deleted the bugfix/627/missing_translation branch June 8, 2020 17:19
@juliusknorr

Copy link
Copy Markdown
Member

/backport c517496 to stable19

@juliusknorr

Copy link
Copy Markdown
Member

/backport c517496 to stable18

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releasebugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No translation - Add notes, lists or links …

2 participants

@georgehrke@juliusknorr