Skip to content

Perform file conflict check earlier so that it also triggers when not saving - #871

Merged
juliusknorr merged 1 commit into
masterfrom
bugfix/851
Jun 16, 2020
Merged

Perform file conflict check earlier so that it also triggers when not saving#871
juliusknorr merged 1 commit into
masterfrom
bugfix/851

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Summary

This makes sure that conflicts with files changed from outside of text are detected on every sync call, not just when trying to save the file back to the storage.

@juliusknorrjuliusknorr added bug Something isn't working 3. to review labels Jun 15, 2020
@juliusknorrjuliusknorr added this to the 20.0.0 milestone Jun 15, 2020
@juliusknorr
juliusknorr requested a review from rullzerJune 15, 2020 08:27
… saving
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that makes sense

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect file chances on sync

3 participants

@juliusknorr@rullzer@MorrisJobke