Skip to content

Check if a file was created manually before creating a new workspace - #904

Merged
juliusknorr merged 2 commits into
masterfrom
bugfix/noid/rich-workspace-check-before-creating
Jul 9, 2020
Merged

Check if a file was created manually before creating a new workspace#904
juliusknorr merged 2 commits into
masterfrom
bugfix/noid/rich-workspace-check-before-creating

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Steps to reproduce the issue:

  • Create a new directory and open it
  • Manually create a README.md file and add some text to it
  • Click on the rich workspace placeholder to create a new file

Before:

  • A second file was created

After:

  • The rich workspace area will show the content of the existing file

As bonus this makes sure that when using external storages with a case-insensitive file system there will not be two separate files with different casing.

…pace
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr added bug Something isn't working 3. to review labels Jun 26, 2020
@juliusknorrjuliusknorr added this to the 20.0.0 milestone Jun 26, 2020
@MorrisJobkeMorrisJobke modified the milestones: 20.0.0, Nextcloud 20Jul 7, 2020
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/compile /

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane!

@juliusknorr
juliusknorr merged commit 1da0582 into masterJul 9, 2020
@juliusknorr
juliusknorr deleted the bugfix/noid/rich-workspace-check-before-creating branch July 9, 2020 07:46
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport 4b3c40b to stable19

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport 4b3c40b to stable18

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@rullzer@MorrisJobke