Uh oh!
There was an error while loading. Please reload this page.
Use IBootstrap for the app bootstrap - #924
Merged
Merged
Conversation
MorrisJobke
requested review from
ChristophWurst, danxuliu, juliusknorr and kesselbJuly 9, 2020 17:56
MorrisJobke
commented
Jul 9, 2020
Uh oh!
There was an error while loading. Please reload this page.
MorrisJobkeforce-pushed
the
feature/noid/use-ibootstrap-for-application
branch
3 times, most recently
from
July 9, 2020 18:18
6c0e34f to
ca2ce1cCompareMorrisJobke
commented
Jul 9, 2020
MemberAuthor
Ready for review and it feels so much better than before :) |
ChristophWurst
approved these changes
Jul 9, 2020
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Best thing that has happened in my life so far
juliusknorr
approved these changes
Jul 10, 2020
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
juliusknorrforce-pushed
the
feature/noid/use-ibootstrap-for-application
branch
from
July 10, 2020 05:58
ca2ce1c to
759d679CompareSigned-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
commented
Jul 10, 2020
Member
Hm cypress fails seem random, and not really related. Let's get this in 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested it and it seemed to work, but please have another look.
Also @ChristophWurst must be proud of this :)