Log the output of 'occ maintenance:mode --off' if it fails

[julien-nc]

If the return code of occ maintenance:mode --off is not 0, we might be interested in the command output.

We can backport this to 31, 30 and 29.

[julien-nc]

It turns out that system just returns what's written in stdout, not stderr (what we are mostly interested in).
How about switching to something like https://www.php.net/manual/fr/function.system.php#94929 ?

[come-nc]

Yeah, do we have a helper somewhere for that?

[skjnldsv]

Any news @julien-nc ? :)

[julien-nc]

@skjnldsv No news. If you and @come-nc are ok with using proc_open() instead of system() to be able to get stderr, I might implement it soon-ish.

[julien-nc]

@skjnldsv@come-nc It now uses proc_open and prints stderr or stdout if they are not empty when the command fails.

[skjnldsv]

you also need make index.php

[julien-nc]

@skjnldsv It does not make any change to index.php if I run make index.php.

[come-nc]

The failure comes from the changes in vendor I think.
Probably you use a different version of composer.