prepare to release in appstore by violoncelloCH · Pull Request #26 · nextcloud/user_external

violoncelloCH · 2018-12-21T16:18:17Z

remove shipped flag
set min-version to 15 (so it can't be installed from store and shipped; for 15.0.0 broken anyway)
bump version to 0.5.0 (.0 as of occ check-code compliance #30)
change Author to "Nextcloud"? -- just do be set in the appstore (certificate for user_external app-certificate-requests#208 (comment))
change build script for 15.0.1 to not include user_external (probably not in this PR - unbundle user_external to release it via appstore server#13225)

for #22

cc @jancborchardt @MariusBluem @rullzer
Signed-off-by: Jonas Sulzer jonas@violoncello.ch

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>

MorrisJobke · 2019-01-02T10:59:35Z

change build script for 15.0.1 to not include user_external (probably not in this PR - nextcloud/server#13225)

I can do this.

MorrisJobke · 2019-01-02T10:59:51Z

I can do this.

But only once this is shipped to the appstore.

MorrisJobke · 2019-01-02T11:00:21Z

One more thing to test: check if this works properly: not that the app is then removed but not fetched from the appstore anymore.

violoncelloCH · 2019-01-02T11:27:27Z

@MorrisJobke

I can do this.

thank you

But only once this is shipped to the appstore.

so I would need nextcloud/app-certificate-requests#208 first, then we can merge this one and after that I could create the appstore release, correct?

not that the app is then removed but not fetched from the appstore anymore.

does this mean it's not installed any more by default? or what does this mean exactly?

@jancborchardt should I change the author of this app to "Nextcloud" or not?

MorrisJobke · 2019-01-02T13:30:40Z

not that the app is then removed but not fetched from the appstore anymore.
does this mean it's not installed any more by default? or what does this mean exactly?

I guess that it could be that the app code is simply not there anymore - which should be avoided.

MorrisJobke · 2019-01-02T13:30:50Z

so I would need nextcloud/app-certificate-requests#208 first, then we can merge this one and after that I could create the appstore release, correct?

Correct 👍

violoncelloCH · 2019-01-02T13:38:53Z

not that the app is then removed but not fetched from the appstore anymore.
does this mean it's not installed any more by default? or what does this mean exactly?
I guess that it could be that the app code is simply not there anymore - which should be avoided.

okay, of course... do you have an idea how to avoid this?

MorrisJobke · 2019-01-02T15:25:06Z

okay, of course... do you have an idea how to avoid this?

Test it extensively and report bugs (if there are any) with clear steps into the server repo.

violoncelloCH · 2019-01-02T22:15:55Z

Test it extensively and report bugs (if there are any) with clear steps into the server repo.

Guess I'll need some help here, sorry.
How can I test this without a release on the appstore?

jancborchardt · 2019-01-04T16:36:58Z

@jancborchardt should I change the author of this app to "Nextcloud" or not?

That’s for @MorrisJobke @rullzer to decide. I’m fine either way.

MorrisJobke · 2019-01-04T22:41:04Z

change Author to "Nextcloud"? -- just do be set in the appstore (nextcloud/app-certificate-requests#208 (comment))

Not needed. Just leave it as it is now.

MorrisJobke · 2019-01-04T22:41:33Z

change build script for 15.0.1 to not include user_external (probably not in this PR - nextcloud/server#13225)

I will change it. It will not be included.

violoncelloCH · 2019-01-04T23:56:12Z

@MorrisJobke
should I create a release now and publish it as soon as possible to be ready for 15.0.1 or should I wait for #30?

What's the best practice for the release? Create a tag, check out the tag, do the code signing, generate the release archive, generate a signature over the archive, create a Github release for the tag and upload it and finally paste the link and the signature to the appstore?

MorrisJobke · 2019-01-05T08:45:09Z

What's the best practice for the release? Create a tag, check out the tag, do the code signing, generate the release archive, generate a signature over the archive, create a Github release for the tag and upload it and finally paste the link and the signature to the appstore?

Looks good 👍

MorrisJobke · 2019-01-05T08:46:13Z

should I create a release now and publish it as soon as possible to be ready for 15.0.1 or should I wait for #30?

If it works now already then do a release now.

violoncelloCH · 2019-01-05T08:51:20Z

If it works now already then do a release now.

It works already (I'll do some more tests), but the appstore documentation says that occ app:check-code should say that the app is "compliant" before uploading it to the appstore. Do you do checks on that and reject "non-complaint" apps?

violoncelloCH · 2019-01-06T22:17:42Z

@MorrisJobke
I tested it again and applied the release on a production instance (the one for our school) and everything worked fine. I then created a github release (https://github.com/nextcloud/user_external/releases/tag/v0.5.0) and uploaded the signature and the link to the archive to the appstore. Hope everything worked fine there, because I didn't get a real feedback on the upload to be completed. (There was no real feedback except a spinning circle on the "Upload" button. The form stayed with the content filled in after the spinning circle disappeared again.) I guess it simply takes some time or need some manual steps on your (nextcloud's) side before the app becomes visible in the appstore?

MorrisJobke · 2019-01-07T09:50:54Z

I guess it simply takes some time or need some manual steps on your (nextcloud's) side before the app becomes visible in the appstore?

Not really. Usually you upload the release (you did it here: https://github.com/nextcloud/user_external/releases/tag/v0.5.0) and then you open the apps.nextcloud.com page to upload an app. There you add the link to the uploaded zip and the signature and press "upload". It then checks this URL and updates the App Store right afterwards. Typically this takes 5 to 10 seconds and the app store shows it.

violoncelloCH · 2019-01-07T10:03:39Z

I pressed upload there and a spinner appeared on the upload button, but nothing else afterwards. I'll try it again, but I don't really know what went wrong.

violoncelloCH · 2019-01-07T10:14:52Z

I signed in via github. Does it have something to do with that maybe? Should I try letting me send a password reset link for the account?

the form just returns to this state, after the spinner on the upload button disappears:

violoncelloCH · 2019-01-07T10:31:11Z

is there something wrong with my signature?
because https://nextcloudappstore.readthedocs.io/en/latest/restapi.html#api-create-release shows a much shorter one as example...?

i generated it with this command openssl dgst -sha512 -sign /home/jonas/.nextcloud/certificates/user_external.key user_external.tar.gz | openssl base64

MorrisJobke · 2019-01-07T11:33:18Z

No - looks like an issue with the app store. Let me check that. There is usually either a success or a failure message at the top (in red or green).

MorrisJobke · 2019-01-07T11:34:35Z

Could you now try again?

violoncelloCH · 2019-01-07T11:38:39Z

still the same...
I get a 500 in network console for https://apps.nextcloud.com/api/v1/apps/releases...

the spinner on the upload button disappears after two or three seconds and there appears no feedback at all

MorrisJobke · 2019-01-07T11:42:23Z

Mmmh ... it says this:

tarfile.ReadError: not a gzip file

MorrisJobke · 2019-01-07T11:43:38Z

Ah ... seems that the file is corrupt. I also can't decompress it on my machine here. Just check it again and just upload again to the release.

violoncelloCH · 2019-01-07T11:51:09Z

ohh, I'm sorry about that! thank you for your help!
i did it with tar -f user_external.tar.gz user_external/... do I need to run gzip on that as well after tar?

MorrisJobke · 2019-01-07T11:57:06Z

https://github.com/nextcloud/jsloader/blob/master/Makefile#L60-L61

Boils down to tar -czf FILENAME folder/. The -z does the gzip compression.

violoncelloCH · 2019-01-07T12:02:18Z

thank you very much!
It finally worked! https://apps.nextcloud.com/apps/user_external

MorrisJobke · 2019-01-07T13:46:27Z

Nice 👍

remove shipped-flag; set min-version to 15; bump version
52a89f7
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>

violoncelloCH added the 2. developing label Dec 21, 2018

violoncelloCH mentioned this pull request Dec 21, 2018
certificate for user_external nextcloud/app-certificate-requests#208
Merged

violoncelloCH added this to the 0.5 milestone Dec 21, 2018

jancborchardt requested review from MorrisJobke and rullzer December 21, 2018 22:02

semantic version number
23dd039
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>

violoncelloCH added 3. to review and removed 2. developing labels Jan 2, 2019

violoncelloCH mentioned this pull request Jan 4, 2019
occ check-code compliance #30
Merged
4 tasks

MorrisJobke mentioned this pull request Jan 4, 2019
15.0.1 RC 1 nextcloud/server#13346
Merged
3 tasks

MorrisJobke approved these changes Jan 4, 2019
View reviewed changes

MorrisJobke merged commit 05fb0e2 into masterJan 4, 2019

MorrisJobke deleted the unbundle_from_release_to_appstore branch January 4, 2019 22:43

violoncelloCH added 4. to release and removed 3. to review labels Jan 4, 2019

jancborchardt mentioned this pull request Jan 7, 2019
Add to app store #22
Closed

MorrisJobke mentioned this pull request Jan 7, 2019
Upload of app with invalid archive fails with 500 nextcloud/appstore#590
Closed

Uh oh!

Conversation

violoncelloCH commented Dec 21, 2018• edited by MorrisJobke Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MorrisJobke commented Jan 2, 2019

Uh oh!

MorrisJobke commented Jan 2, 2019

Uh oh!

MorrisJobke commented Jan 2, 2019

Uh oh!

violoncelloCH commented Jan 2, 2019

Uh oh!

MorrisJobke commented Jan 2, 2019

Uh oh!

MorrisJobke commented Jan 2, 2019

Uh oh!

violoncelloCH commented Jan 2, 2019

Uh oh!

MorrisJobke commented Jan 2, 2019

Uh oh!

violoncelloCH commented Jan 2, 2019

Uh oh!

jancborchardt commented Jan 4, 2019

Uh oh!

MorrisJobke commented Jan 4, 2019

Uh oh!

MorrisJobke commented Jan 4, 2019

Uh oh!

violoncelloCH commented Jan 4, 2019

Uh oh!

MorrisJobke commented Jan 5, 2019

Uh oh!

MorrisJobke commented Jan 5, 2019

Uh oh!

violoncelloCH commented Jan 5, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

violoncelloCH commented Jan 6, 2019

Uh oh!

MorrisJobke commented Jan 7, 2019

Uh oh!

violoncelloCH commented Jan 7, 2019

Uh oh!

violoncelloCH commented Jan 7, 2019

Uh oh!

violoncelloCH commented Jan 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MorrisJobke commented Jan 7, 2019

Uh oh!

MorrisJobke commented Jan 7, 2019

Uh oh!

violoncelloCH commented Jan 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MorrisJobke commented Jan 7, 2019

Uh oh!

MorrisJobke commented Jan 7, 2019

Uh oh!

violoncelloCH commented Jan 7, 2019

Uh oh!

MorrisJobke commented Jan 7, 2019

Uh oh!

violoncelloCH commented Jan 7, 2019

Uh oh!

MorrisJobke commented Jan 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

violoncelloCH commented Dec 21, 2018•
edited by MorrisJobke
Loading

violoncelloCH commented Jan 5, 2019•
edited
Loading

violoncelloCH commented Jan 7, 2019•
edited
Loading

violoncelloCH commented Jan 7, 2019•
edited
Loading