Uh oh!
There was an error while loading. Please reload this page.
[main] Update nextcloud/ocp dependency - #406
Merged
Merged
Conversation
Pytalforce-pushed
the
automated/noid/main-update-nextcloud-ocp
branch
from
May 3, 2023 00:47
ea518f1 to
550d1cfComparePytal
commented
May 3, 2023
Member
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
automated/noid/main-update-nextcloud-ocp
branch
from
May 3, 2023 00:50
550d1cf to
862a8bdComparePytal
approved these changes
May 3, 2023
come-nc
reviewed
May 4, 2023
| } | ||
| } | ||
| return $size; | ||
| return (int)$size; |
Collaborator
There was a problem hiding this comment.
Will fail on 32bits for more than 4GB (or 2GB because signed?).
Should we move all int to int|float for filesizes 32bit support?
Member
There was a problem hiding this comment.
🤔 yep 2GB max cause signed https://www.php.net/manual/en/reserved.constants.php#reserved.constants.core
32-bit support added in:
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated update of nextcloud/ocp dependency