Uh oh!
There was an error while loading. Please reload this page.
Support reverse proxy the NextCloud way - #318
Open
Toilal wants to merge 2 commits into
Open
Conversation
hairmare
commented
May 16, 2019
Safari and Firefox both seem to currently display a security warning due to |
rullzer
commented
May 28, 2019
Member
Right. It makes sense... let me see if I can do a test setup with this. |
Toilalforce-pushed
the
reverse-proxy-fix
branch
2 times, most recently
from
June 8, 2019 22:36
f293513 to
17a24e5CompareToilal
commented
Jun 8, 2019
Author
I have rebased on current master. @rullzer Have you made some tests with those changes ? |
blizzz
commented
May 2, 2025
Member
I am going through the open PRs and a there is a bunch of dusty ones here 😅 Rebased this one. I understand this is still relevant. |
In some network configurations involving a reverse proxy, the base url generated by the underlying SAML library is not consistent with the way it's generated in NextCloud. For example, it may generate `http://` urls instead of `https://` when the SSL Layer is handled by a proxy, even when NextCloud URLGenerator#getAbsoluteURL effectively generates `https://` urls. This change setup SAML library to use the Server Protocol and Server Host as returned by the NextCloud Request object to build SAML urls properly. Signed-off-by: Rémi Alvergnat <remi.alvergnat@gfi.fr>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some network configurations involving a reverse proxy, the base url generated by the underlying SAML library is not consistent with the way it's generated in NextCloud.
For example, it may generate
http://urls instead ofhttps://when the SSL Layer is handled by a proxy, even when NextCloud URLGenerator#getAbsoluteURL effectively generateshttps://urls.This change setup SAML library to use the Server Protocol and Server Host as returned by the NextCloud Request object to build SAML urls properly.