Skip to content

Update @nextcloud/vue to 6.0.0 - #1319

Merged
skjnldsv merged 9 commits into
masterfrom
dependencies/nextcloud-vue6
Aug 23, 2022
Merged

Update @nextcloud/vue to 6.0.0#1319
skjnldsv merged 9 commits into
masterfrom
dependencies/nextcloud-vue6

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Aug 11, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@juliusknorrjuliusknorr mentioned this pull request Aug 11, 2022
Merged
Base automatically changed from dependabot/npm_and_yarn/vue-2.7.8 to masterAugust 11, 2022 11:02
@juliusknorr
juliusknorrforce-pushed the dependencies/nextcloud-vue6 branch from feef129 to 91e5084CompareAugust 11, 2022 12:10
@juliusknorr

juliusknorr commented Aug 11, 2022

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@nextcloud-command
nextcloud-commandforce-pushed the dependencies/nextcloud-vue6 branch from 91e5084 to d7ab8b5CompareAugust 11, 2022 13:02
@juliusknorr
juliusknorrforce-pushed the dependencies/nextcloud-vue6 branch 3 times, most recently from 97eb4ef to 728881aCompareAugust 12, 2022 10:39
@skjnldsv
skjnldsvforce-pushed the dependencies/nextcloud-vue6 branch from a2fb110 to 7e61528CompareAugust 18, 2022 11:29
skjnldsv
skjnldsv reviewed Aug 18, 2022
View reviewed changes
Comment threadsrc/views/Viewer.vue
}
}

&.theme--dark::v-deep .button-vue--vue-tertiary {

@skjnldsvskjnldsvAug 18, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to enforce the theme used more beautifully with css variables now
As well with the data-theme attribute @juliushaertl

@skjnldsv
skjnldsvforce-pushed the dependencies/nextcloud-vue6 branch from dfeedb6 to 0fb6d8cCompareAugust 18, 2022 17:36
@skjnldsvskjnldsv added the 2. developing Work in progress label Aug 18, 2022
@skjnldsvskjnldsv self-assigned this Aug 18, 2022
@skjnldsvskjnldsv added this to the Nextcloud 25 milestone Aug 18, 2022
@skjnldsvskjnldsv changed the title Update @nextcloud/vue to 6.0.0-beta.1Update @nextcloud/vue to 6.0.0Aug 18, 2022
@skjnldsv

skjnldsv commented Aug 18, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@juliushaertl do you know how we can adjust that here? Also the editor popups/modals
image
Getting the dom elements might be tricky as they come and go on the editor menu open/close 😕

@juliusknorr
juliusknorrforce-pushed the dependencies/nextcloud-vue6 branch from 0fb6d8c to 32698b1CompareAugust 19, 2022 08:50
@juliusknorr

juliusknorr commented Aug 19, 2022

Copy link
Copy Markdown
MemberAuthor

Popovers like the ones from actions should be handled separately anyways by their own focus trap. Maybe you can share what the SfxModal-Wrapper does and how it gets initialised?

@skjnldsv

skjnldsv commented Aug 19, 2022

Copy link
Copy Markdown
Member

Popovers like the ones from actions should be handled separately anyways by their own focus trap. Maybe you can share what the SfxModal-Wrapper does and how it gets initialised?

External liv, this is either the SaveAs modal
image

Or the menus like this
image

@skjnldsvskjnldsv mentioned this pull request Aug 19, 2022
Merged
@juliusknorr

juliusknorr commented Aug 22, 2022

Copy link
Copy Markdown
MemberAuthor

Is there any way you could trigger a callback on showing/hiding those? I assume they are handled fully by the image editor library :/

@skjnldsv

skjnldsv commented Aug 22, 2022

Copy link
Copy Markdown
Member

I assume they are handled fully by the image editor library :/

Yep!
I'll double check. But we might have to fix the focus trap

@vinicius73vinicius73 mentioned this pull request Aug 23, 2022
Closed
2 tasks
@skjnldsv
skjnldsvforce-pushed the dependencies/nextcloud-vue6 branch from 32698b1 to 7a121e5CompareAugust 23, 2022 13:58
@skjnldsv

skjnldsv commented Aug 23, 2022

Copy link
Copy Markdown
Member

Is there any way you could trigger a callback on showing/hiding those? I assume they are handled fully by the image editor library :/

Fixed, not super fond, but works™

@juliusknorr@skjnldsv
Bump @nextcloud/vue to 6.0.0-beta.1
9dee4d9
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr@skjnldsv
Show close button in the usual position
641de95
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr@skjnldsv
Overwrite focus/hover styles as we use the button on a dark backgorund
9a83744
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr@skjnldsv
Bump @nextcloud/vue to 6.0.0-beta.2
365cdde
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr@skjnldsv
Adjust cypress tests to match next/prev buttons
49a7db1
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrand others added 3 commits August 23, 2022 17:35
@juliusknorr@skjnldsv
Pass the sidebar as additional focus trap element
438dac6
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@skjnldsv
Bump @nextcloud/vue to beta 3
c6774a6
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Fix image editor modal trap
86860c0
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the dependencies/nextcloud-vue6 branch from 7a121e5 to 61ee392CompareAugust 23, 2022 15:37
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 23, 2022
@skjnldsvskjnldsv added the dependencies Pull requests that update a dependency file label Aug 23, 2022
@skjnldsv
skjnldsv enabled auto-merge August 23, 2022 15:39
@skjnldsv
Bump @nextcloud/vue to beta 4
9320acb
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the dependencies/nextcloud-vue6 branch from 61ee392 to 9320acbCompareAugust 23, 2022 15:49
@skjnldsv
skjnldsv merged commit 1aa8f17 into masterAug 23, 2022
@skjnldsv
skjnldsv deleted the dependencies/nextcloud-vue6 branch August 23, 2022 16:16
@blizzzblizzz mentioned this pull request Aug 24, 2022
Merged
@kesselbkesselb mentioned this pull request Jun 23, 2025
Closed
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request#1319from nextcloud/dependencies/nextcloud-vue6
fd070c8
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request#1319from nextcloud/dependencies/nextcloud-vue6
164bd63
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request#1319from nextcloud/dependencies/nextcloud-vue6
ad10620
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request#1319from nextcloud/dependencies/nextcloud-vue6
f55a3df
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request#1319from nextcloud/dependencies/nextcloud-vue6
f71dcf2
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request#1319from nextcloud/dependencies/nextcloud-vue6
b400c23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishdependenciesPull requests that update a dependency file

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

2 participants

@juliusknorr@skjnldsv