Uh oh!
There was an error while loading. Please reload this page.
enh: add data-handler when attached to el - #1371
Merged
Merged
Conversation
szaimen
reviewed
Sep 14, 2022
Uh oh!
There was an error while loading. Please reload this page.
max-nextcloud added a commit
to nextcloud/server
that referenced
this pull request
Sep 14, 2022
Based on nextcloud/viewer#1371 . If we are displaying an audio file in a single page share provide enough margin to display the speed settings. Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
enh/data-handler-when-attached-to-el
branch
from
September 14, 2022 09:14
11d03d2 to
b8cd522Compareskjnldsv
approved these changes
Sep 14, 2022
max-nextcloud
enabled auto-merge
September 14, 2022 09:16
szaimen
commented
Sep 14, 2022
Contributor
/compile amend / |
Also provide a data-handler attribute to the viewer div when the viewer is attached to a dom element other than the modal. Signed-off-by: Max <max@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
enh/data-handler-when-attached-to-el
branch
from
September 14, 2022 09:48
b8cd522 to
488d223Comparesusnux pushed a commit
that referenced
this pull request
May 16, 2026
…d-to-el enh: add data-handler when attached to el
susnux pushed a commit
that referenced
this pull request
May 16, 2026
…d-to-el enh: add data-handler when attached to el
susnux pushed a commit
that referenced
this pull request
May 16, 2026
…d-to-el enh: add data-handler when attached to el
susnux pushed a commit
that referenced
this pull request
May 16, 2026
…d-to-el enh: add data-handler when attached to el
susnux pushed a commit
that referenced
this pull request
May 16, 2026
…d-to-el enh: add data-handler when attached to el
susnux pushed a commit
that referenced
this pull request
May 16, 2026
…d-to-el enh: add data-handler when attached to el
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also provide a data-handler attribute to the viewer div when the viewer is attached to a dom element other than the modal.