Skip to content

Use preview endpoint for images - #33

Merged
skjnldsv merged 2 commits into
masterfrom
enhancemet/preview/use-preview-endpoint
Mar 14, 2019
Merged

Use preview endpoint for images#33
skjnldsv merged 2 commits into
masterfrom
enhancemet/preview/use-preview-endpoint

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Fix#28

@skjnldsvskjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Mar 14, 2019
@skjnldsvskjnldsv added this to the next milestone Mar 14, 2019
@skjnldsvskjnldsv self-assigned this Mar 14, 2019
@ariselseng

ariselseng commented Mar 14, 2019

Copy link
Copy Markdown
Member

@skjnldsv
Code looks good. Though In my opinion we should just drop the getMime() in Viewer.vue.
The mime should come from Nextcloud.

It would be very nice if this app could view anything that had had the following conditions: image/** as mimetype and nc:has-previewtrue</nc:has-preview>. That way apps (like mine: https://github.com/cowai/camerarawpreviews) providing previews for other image file types could just work without any integration.

If you look here in my little patch: https://gist.github.com/cowai/1a314c1f32f789ce20b84448cf94be25
You can see that the module 'mime-types' is quite limiting.

EDIT: image/x-dcraw has like 15 different extensions. So it just won't work using that module I think ;)

@skjnldsv

skjnldsv commented Mar 14, 2019

Copy link
Copy Markdown
MemberAuthor

@cowai Sure, I have a pending branch for that like said in #25 (comment) :)
Let me push it

EDIT: #34

@ariselsengariselseng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@skjnldsv
skjnldsvforce-pushed the enhancemet/preview/use-preview-endpoint branch from f56fd76 to b7e083fCompareMarch 14, 2019 13:01
Comment threadsrc/views/Viewer.vue
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the enhancemet/preview/use-preview-endpoint branch from b7e083f to 3b98dd9CompareMarch 14, 2019 13:16
@skjnldsv
skjnldsv merged commit 4688d15 into masterMar 14, 2019
@skjnldsv
skjnldsv deleted the enhancemet/preview/use-preview-endpoint branch March 14, 2019 13:58
@MorrisJobkeMorrisJobke mentioned this pull request Mar 20, 2019
9 tasks
@skjnldsvskjnldsv modified the milestones: next, Nextcloud 16Apr 17, 2019
susnux pushed a commit that referenced this pull request May 16, 2026
susnux pushed a commit that referenced this pull request May 16, 2026
susnux pushed a commit that referenced this pull request May 16, 2026
susnux pushed a commit that referenced this pull request May 16, 2026
susnux pushed a commit that referenced this pull request May 16, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use previews

2 participants

@skjnldsv@ariselseng